[
https://issues.apache.org/jira/browse/FLINK-3300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123338#comment-15123338
]
ASF GitHub Bot commented on FLINK-3300:
---------------------------------------
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/1561
[FLINK-3300] fix concurrency bug in YarnJobManager
Adds message passing between Hadoop's async resource manager client and
the YarnJobManager actor.
It helps to view the diff with ignored whitespace (`?w=1`).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-3300
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1561.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1561
----
commit 2a8966dc9fd0f14f2fdae2b5cf70441ba505bb8a
Author: Maximilian Michels <m...@apache.org>
Date: 2016-01-29T10:21:08Z
[FLINK-3300] fix concurrency bug in YarnJobManager
Adds message passing between Hadoop's async resource manager client and
the YarnJobManager actor.
----
> Concurrency Bug in Yarn JobManager
> ----------------------------------
>
> Key: FLINK-3300
> URL: https://issues.apache.org/jira/browse/FLINK-3300
> Project: Flink
> Issue Type: Bug
> Components: JobManager
> Affects Versions: 1.0.0
> Reporter: Stephan Ewen
> Assignee: Maximilian Michels
> Priority: Blocker
> Fix For: 1.0.0
>
>
> The change to use the async ResourceManager client introduced concurrency
> problems: The ResourceManager callback threads run and change data structures
> at the same time as the actor methods, voiding the actor concurrency model.
> One example that can happen is that the callback tries to start containers
> while the ContainerLaunchContext is still not set (because the actor method
> is still in the StartYarnSession method).
> Bug introducing commit:
> https://github.com/apache/flink/commit/4e52fe4304566e5239996b3d48290e0c1f0772e8
> Quick fix could be to revert the commit. Better solution would be to let the
> callback methods send actor messages to the YobManager, rather than directly
> acting.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
