wuchong commented on a change in pull request #12527:
URL: https://github.com/apache/flink/pull/12527#discussion_r437368061
##########
File path: flink-dist/src/main/assemblies/bin.xml
##########
@@ -84,6 +84,28 @@ under the License.
<fileMode>0644</fileMode>
</file>
+ <!-- Built-in formats -->
+ <file>
+
<source>../flink-formats/flink-csv/target/flink-csv-${project.version}.jar</source>
+ <outputDirectory>lib/</outputDirectory>
+ <destName>flink-csv-${project.version}.jar</destName>
Review comment:
Not sure, but shall we use `flink-csv-xxx-sql-jar.jar`?
##########
File path: flink-dist/src/main/assemblies/bin.xml
##########
@@ -84,6 +84,28 @@ under the License.
<fileMode>0644</fileMode>
</file>
+ <!-- Built-in formats -->
+ <file>
+
<source>../flink-formats/flink-csv/target/flink-csv-${project.version}.jar</source>
+ <outputDirectory>lib/</outputDirectory>
+ <destName>flink-csv-${project.version}.jar</destName>
Review comment:
Shall we remove `sql-jar` since there is no difference between them so
far, and it confuses users? cc @twalthr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
