dawidwys commented on a change in pull request #12335:
URL: https://github.com/apache/flink/pull/12335#discussion_r436677768
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java
##########
@@ -146,6 +152,10 @@ public CatalogManager build() {
}
}
+ public void setCatalogTableSchemaResolver(CatalogTableSchemaResolver
schemaResolver) {
Review comment:
argh, I missed that dependency. I can't think of a better solution now.
Let's then go with the `setter` approach. Could you add a short comment on the
setter why do we have it instead of passing it in ctor?
I think the first paragraph from your answer would work:
```
We do not pass it in the ctor, because we need a {@link Parser} that is
constructed in a {@link Planner}. At the same time {@link Planner} needs a
{@link CatalogManager} to be constructed. Thus we can't get {@link Parser}
instance when creating a {@link CatalogManager}. See {@link
TableEnvironmentImpl#create}.
```
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java
##########
@@ -146,6 +152,10 @@ public CatalogManager build() {
}
}
+ public void setCatalogTableSchemaResolver(CatalogTableSchemaResolver
schemaResolver) {
Review comment:
argh, I missed that dependency. I can't think of a better solution now.
Let's then go with the `setter` approach. Could you add a short comment on the
setter why do we have it instead of passing it in ctor?
I think the first paragraph from your answer would work:
```
/**
* We do not pass it in the ctor, because we need a {@link Parser} that is
constructed in a
* {@link Planner}. At the same time {@link Planner} needs a {@link
CatalogManager} to
* be constructed. Thus we can't get {@link Parser} instance when creating a
{@link
* CatalogManager}. See {@link TableEnvironmentImpl#create}.
*/
```
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/delegation/Parser.java
##########
@@ -58,7 +58,7 @@
UnresolvedIdentifier parseIdentifier(String identifier);
/**
- * Entry point for parse sql expression expressed as a String.
+ * Entry point for parsing sql expression expressed as a String.
Review comment:
```suggestion
* Entry point for parsing SQL expressions expressed as a String.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
