azagrebin commented on a change in pull request #12551:
URL: https://github.com/apache/flink/pull/12551#discussion_r437514848
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/util/config/memory/jobmanager/JobManagerFlinkMemoryUtils.java
##########
@@ -41,9 +41,8 @@ public JobManagerFlinkMemory
deriveFromRequiredFineGrainedOptions(Configuration
MemorySize derivedTotalFlinkMemorySize =
jvmHeapMemorySize.add(offHeapMemorySize);
if (config.contains(JobManagerOptions.TOTAL_FLINK_MEMORY)) {
- // derive network memory from total flink memory, and
check against network min/max
MemorySize totalFlinkMemorySize =
ProcessMemoryUtils.getMemorySizeFromConfig(config,
JobManagerOptions.TOTAL_FLINK_MEMORY);
- if (derivedTotalFlinkMemorySize.getBytes() !=
totalFlinkMemorySize.getBytes()) {
+ if (derivedTotalFlinkMemorySize.getBytes() >
totalFlinkMemorySize.getBytes()) {
Review comment:
The check is correct in this case, the message is wrong, it should `does
not match` instead of `exceeds`.
This has been fixed in
https://github.com/apache/flink/pull/12557/files#diff-4ccfda6492f20dce963a7fa12cc240ebR65.
Therefore, I suggest to close this PR for now.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/util/config/memory/jobmanager/JobManagerFlinkMemoryUtils.java
##########
@@ -41,9 +41,8 @@ public JobManagerFlinkMemory
deriveFromRequiredFineGrainedOptions(Configuration
MemorySize derivedTotalFlinkMemorySize =
jvmHeapMemorySize.add(offHeapMemorySize);
if (config.contains(JobManagerOptions.TOTAL_FLINK_MEMORY)) {
- // derive network memory from total flink memory, and
check against network min/max
MemorySize totalFlinkMemorySize =
ProcessMemoryUtils.getMemorySizeFromConfig(config,
JobManagerOptions.TOTAL_FLINK_MEMORY);
- if (derivedTotalFlinkMemorySize.getBytes() !=
totalFlinkMemorySize.getBytes()) {
+ if (derivedTotalFlinkMemorySize.getBytes() >
totalFlinkMemorySize.getBytes()) {
Review comment:
The check is correct in this case, the message is wrong, it should be
`does not match` instead of `exceeds`.
This has been fixed in
https://github.com/apache/flink/pull/12557/files#diff-4ccfda6492f20dce963a7fa12cc240ebR65.
Therefore, I suggest to close this PR for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
