wangyang0918 commented on a change in pull request #12549:
URL: https://github.com/apache/flink/pull/12549#discussion_r437844204
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/cli/GenericCLI.java
##########
@@ -44,19 +44,23 @@
* for further parsing.
*/
@Internal
-public class ExecutorCLI implements CustomCommandLine {
+public class GenericCLI implements CustomCommandLine {
- private static final Logger LOG =
LoggerFactory.getLogger(ExecutorCLI.class);
+ private static final Logger LOG =
LoggerFactory.getLogger(GenericCLI.class);
private static final String ID = "Generic CLI";
private final Option executorOption = new Option("e", "executor", true,
- "The name of the executor to be used for executing the
given job, which is equivalent " +
+ "DEPRECATED: Please use the -t option instead which is
also available with the \"Application Mode\".\n" +
Review comment:
I am not sure whether we need to update the existing usage of
`-e/--executor`. For example, here[1] in the native K8s document.
[1].
https://ci.apache.org/projects/flink/flink-docs-master/ops/deployment/native_kubernetes.html#submitting-jobs-to-an-existing-session
##########
File path: docs/ops/deployment/yarn_setup.md
##########
@@ -251,6 +250,31 @@ The user-jars position in the class path can be controlled
by setting the parame
- `FIRST`: Adds the jar to the beginning of the system class path.
- `LAST`: Adds the jar to the end of the system class path.
+## Run an application in Application Mode
+
+To launch an application in [Application Mode]({% link ops/deployment/index.md
%}#deployment-modes), you can type:
+
+{% highlight bash %}
+./bin/flink run-application -t yarn-application ./examples/batch/WordCount.jar
+{% endhighlight %}
+
+<div class="alert alert-info" markdown="span">
+ <strong>Attention:</strong> Apart from the `-t`, all other configuration
parameters, such as the path
+ to the savepoint to be used to bootstrap the application's state, the
application parallelism or the
+ required job manager/task manager memory sizes, can be specified by their
configuration option,
+ prefixed by `-D`.
+</div>
+
+As an example, the command to specify the memory sizes of the JM and the TM,
looks like:
+
+{% highlight bash %}
+./bin/flink run-application -t yarn-application
-Djobmanager.memory.process.size=2048m -Dtaskmanager.memory.process.size=4096m
./examples/batch/WordCount.jar
+{% endhighlight %}
+
Review comment:
I suggest to add `remote user jar` and `provided lib` support in the
document. It will make the submission more like a pure application. Almost
everything is done on the cluster side. Starting a Flink application will be
very fast.
Maybe it is out of the scope of this PR. And we do it in a separate one
later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
