zoudan commented on a change in pull request #12542:
URL: https://github.com/apache/flink/pull/12542#discussion_r437995955
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/data/util/DataFormatConverters.java
##########
@@ -1138,7 +1138,7 @@ private ArrayData toBinaryArray(T[] value) {
}
}
reuseWriter.complete();
- return reuseArray;
+ return reuseArray.copy();
Review comment:
Add tests for this.
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/data/util/DataFormatConverters.java
##########
@@ -1138,7 +1138,7 @@ private ArrayData toBinaryArray(T[] value) {
}
}
reuseWriter.complete();
- return reuseArray;
+ return reuseArray.copy();
Review comment:
Also fixed in ArrayObjectArrayConverter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
