danny0405 commented on a change in pull request #12536:
URL: https://github.com/apache/flink/pull/12536#discussion_r438016435
##########
File path:
flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/options/HBaseWriteOptions.java
##########
@@ -100,19 +98,15 @@ public static Builder builder() {
*/
public static class Builder {
- // default is 2mb which is defined in hbase
private long bufferFlushMaxSizeInBytes =
ConnectionConfiguration.WRITE_BUFFER_SIZE_DEFAULT;
- private long bufferFlushMaxRows = -1;
- private long bufferFlushIntervalMillis = -1;
+ private long bufferFlushMaxRows = 0;
Review comment:
I would prefer `-1` as the default value, which means the value is not
set. `0` seems to mean "never flush" .
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactory.java
##########
@@ -277,10 +277,10 @@ private void validateConfigOptions(ReadableConfig config)
{
final Optional<JdbcDialect> dialect = JdbcDialects.get(jdbcUrl);
checkState(dialect.isPresent(), "Cannot handle such jdbc url: "
+ jdbcUrl);
- if (config.getOptional(USERNAME).isPresent()) {
- checkState(config.getOptional(PASSWORD).isPresent(),
- "Database username must be provided when
database password is provided");
- }
+ checkAllOrNone(config, new ConfigOption[]{
Review comment:
Validation for `URL` and `TABLE_NAME` is not necessary because the find
service already does that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
