zentol commented on a change in pull request #12560:
URL: https://github.com/apache/flink/pull/12560#discussion_r438070483
##########
File path:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/history/HistoryServerTest.java
##########
@@ -217,11 +219,19 @@ private void runArchiveExpirationTest(boolean
cleanupExpiredJobs) throws Excepti
.map(JobID::toString)
.filter(jobId -> jobId.equals(jobIdToDelete))
.count());
+ assertHSFilesExistence(jobIdToDelete,
!cleanupExpiredJobs);
Review comment:
This test is written more from a user perspective, and as such I'd
prefer if we instead check that `/job/<jobId>/overview` does (not) return a
404, instead of diving into the nitty-gritty details of how the files are
stored on disk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
