[
https://issues.apache.org/jira/browse/FLINK-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126148#comment-15126148
]
ASF GitHub Bot commented on FLINK-3301:
---------------------------------------
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1560#discussion_r51408033
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/MessageAcknowledgingSourceBase.java
---
@@ -177,21 +177,19 @@ protected boolean addId(UId uid) {
}
@Override
- public void restoreState(SerializedCheckpointData[] state) throws
Exception {
--- End diff --
You should consider pulling the latest master version then.
> Ineffective synchronization in MessageAcknowledgingSourceBase#restoreState
> --------------------------------------------------------------------------
>
> Key: FLINK-3301
> URL: https://issues.apache.org/jira/browse/FLINK-3301
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
>
> Here is related code:
> {code}
> public void restoreState(SerializedCheckpointData[] state) throws Exception
> {
> synchronized (pendingCheckpoints) {
> pendingCheckpoints = SerializedCheckpointData.toDeque(state,
> idSerializer);
> {code}
> When lock is held on current pendingCheckpoints field, new reference is
> assigned to the same field - making the synchronization ineffective.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
