[
https://issues.apache.org/jira/browse/FLINK-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126651#comment-15126651
]
ASF GitHub Bot commented on FLINK-3303:
---------------------------------------
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/1570
[FLINK-3303] Move all non-batch specific classes in "flink-java" to
"flink-core"
Currently, `flink-java` has a lot of classes that are also needed by the
streaming API. For some future changes, some of them need to be used by classes
in `flink-core`. In particular, certain improvements to the state API are
blocked by the fact that certain classes are not in `flink-core`.
This pull request moves classes from `flink-java` to `flink-core` after the
following pattern:
- `flink-core` will contain all classes that are common across the batch
and streaming API.
- `flink-java` will contain all batch API specific classes (we may
eventually even think about renaming it to "flink-batch-java").
Because `flink-java` references `flink-core`, the relocation part is not a
breaking change.
### Breaking parts
This pull request contains [FLINK-3049], relocating the `Either` type to
`org.apache.flink.types`, from `org.apache.flink.api.java.typeutils`.
### Changes besides moving files to another project
- The `Keys` class is now part of `flink-core`. Utility behavior to
inject key-extracting mappers was pulled out into a separate utility class. The
class was also moved to `o.a.f.api.common.operators` from
`o.a.f.api.java.operators`. Since that class is not public API, this change is
not API breaking.
- Lots of tests are now also part of `flink-core`. Minor package
relocations on the tests (naturally not breaking).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephanEwen/incubator-flink move_to_core
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1570.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1570
----
commit 2eccea20421cc22d24f219703aabc3d4da0ee1ac
Author: Stephan Ewen <[email protected]>
Date: 2016-01-31T22:08:18Z
[FLINK-3303] [core] Move Tuple classes to flink-core
commit 2b756aa2a819e4f65f8c45a0b85258129be70b2f
Author: Stephan Ewen <[email protected]>
Date: 2016-01-31T22:27:36Z
[FLINK-3049] [api breaking] Move 'Either' type to 'flink-core /
org.apache.flink.types'
commit 334d83204b933023728939d038478b66c1065280
Author: Stephan Ewen <[email protected]>
Date: 2016-01-31T22:28:32Z
[FLINK-3303] [core] Move all type utilities to flink-core
----
> Move all non-batch specific classes in flink-java to flink-core
> ---------------------------------------------------------------
>
> Key: FLINK-3303
> URL: https://issues.apache.org/jira/browse/FLINK-3303
> Project: Flink
> Issue Type: Improvement
> Components: Core, Java API
> Affects Versions: 0.10.0
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
> Fix For: 1.0.0
>
>
> Currently, {{flink-java}} has a lot of classes that are also needed by the
> streaming api and that are useful to the classes in {{flink-core}}.
> In particular, certain improvements to the state API are blocked by the fact
> that certain classes are not in {{flink-core}}.
> I suggest to move classes from {{flink-java}} to {{flink-core}} after the
> following pattern:
> - {{flink-core}} will contain all classes that are common across the batch
> and streaming API.
> - {{flink-java}} will contain all batch API specific classes (we may
> eventually even think about renaming it to {{flink-batch-java}}.
> Because {{flink-java}} references {{flink-core}}, this will not be a breaking
> change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
