xintongsong opened a new pull request #12620:
URL: https://github.com/apache/flink/pull/12620


   ## What is the purpose of the change
   
   This PR fixes the problem that `ActiveResourceManager` may request 
unnecessary extra workers on termination of existing workers.
   
   ## Brief change log
   
   The equation previously used by `ActiveResourceManager` for deciding whether 
and how many new workers to request on termination of existing workers is:
   `workersToRequest = workersRequiredBySlotManager - 
workersRequestedByResourceManagerNotAllocated`
   
   If there are workers allocated, being started but not yet registered, 
unnecessary new workers will be requested.
   
   Now the equation is changed to: 
   `workersToRequest = workersRequiredBySlotManager - 
workersRequestedByResourceManagerNotRegistered`
   
   ## Verifying this change
   
   New test cases added in `KubernetesResourceManagerTest` and 
`YarnResourceManagerTest`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to