[
https://issues.apache.org/jira/browse/FLINK-18245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133936#comment-17133936
]
Xintong Song commented on FLINK-18245:
--------------------------------------
I'm okay with having such disabled values. However, I want to bring the
following things to attention.
* A {{MemorySize}} should never be negative. We rely on this assumption for
sanity checks in many places in memory calculations. If we introduce the
disabled values, it would be good that {{Configuration}} recognizes such
values, and returns {{defaultValue}} / {{Optional.empty()}} when {{get()}} /
{{getOptional()}} is called on them.
* We also rely on {{Configuration.contains}} & {{Configuration.containsKey}}
to decide whether a configuration option is specified or not. If we introduce
the disabled values, it would be good that these two methods returns {{false}}
on such disabled values.
> Support to parse -1 for MemorySize and Duration ConfigOption
> ------------------------------------------------------------
>
> Key: FLINK-18245
> URL: https://issues.apache.org/jira/browse/FLINK-18245
> Project: Flink
> Issue Type: New Feature
> Components: API / Core
> Reporter: Jark Wu
> Priority: Major
>
> Currently, MemorySize and Duration ConfigOption doesn't support to parse
> {{-1}} or {{-1s}}.
> {code:java}
> java.lang.NumberFormatException: text does not start with a number
> at
> org.apache.flink.configuration.MemorySize.parseBytes(MemorySize.java:294)
> {code}
> That makes us can't to use {{-1}} as a disabled value, and have to use {{0}}
> which may confuse users at some senarios.
> There is some discussion around this topic in
> :https://github.com/apache/flink/pull/12536#discussion_r438019632
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
