klion26 commented on a change in pull request #247: URL: https://github.com/apache/flink-web/pull/247#discussion_r439216882
########## File path: contributing/code-style-and-quality-components.zh.md ########## @@ -48,96 +47,95 @@ How to name config keys: } ``` -* The resulting config keys should hence be: +* 因此生成的配置键应该： - **NOT** `"taskmanager.detailed.network.metrics"` + **不是** `"taskmanager.detailed.network.metrics"` - **But rather** `"taskmanager.network.detailed-metrics"` + **而是** `"taskmanager.network.detailed-metrics"` -### Connectors +### 连接器 -Connectors are historically hard to implement and need to deal with many aspects of threading, concurrency, and checkpointing. +连接器历来很难实现，需要处理多线程、并发和检查点等许多方面。 -As part of [FLIP-27](https://cwiki.apache.org/confluence/display/FLINK/FLIP-27%3A+Refactor+Source+Interface) we are working on making this much simpler for sources. New sources should not have to deal with any aspect of concurrency/threading and checkpointing any more. +作为 [FLIP-27](https://cwiki.apache.org/confluence/display/FLINK/FLIP-27%3A+Refactor+Source+Interface) 的一部分，我们正在努力实现数据源（source）。新的数据源应该不必处理并发/线程和检查点的任何方面。 Review comment: `作为 [FLIP-27](https://cwiki.apache.org/confluence/display/FLINK/FLIP-27%3A+Refactor+Source+Interface) 的一部分，我们正在努力实现数据源（source）` 这句话感觉不完整，正在实现数据源，然后就没了，和原文也有一点不太一样，原文是说使得 source 的实现更简单了 ########## File path: contributing/code-style-and-quality-components.zh.md ########## @@ -9,24 +9,23 @@ title: "Apache Flink Code Style and Quality Guide — Components" -## Component Specific Guidelines +## 组件特定指南 -_Additional guidelines about changes in specific components._ +_关于特定组件更改的附加指南。_ -### Configuration Changes +### 配置更改 -Where should the config option go? +配置选项应该放在哪里？ -* <span style="text-decoration:underline;">‘flink-conf.yaml’:</span> All configuration that pertains to execution behavior that one may want to standardize across jobs. Think of it as parameters someone would set wearing an “ops” hat, or someone that provides a stream processing platform to other teams. +* <span style="text-decoration:underline;">‘flink-conf.yaml’:</span> 所有属于可能要跨作业标准化的执行行为配置。可以将其想像成 Ops 的工作人员，或为其他团队提供流处理平台的人。 Review comment: 我重新看了下。这里的意思是说 “flink-conf” 里面的参数是 ops 人员设置的吧，不是说这个是 ops 工作人员？ 这里是说 flink-conf 是 ops 工作人员或者提供平台的工作人员会统一设置的参数？ 可以想下如何描述会更好~ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
