rmetzger commented on a change in pull request #12622:
URL: https://github.com/apache/flink/pull/12622#discussion_r439372187
##########
File path:
flink-formats/flink-sql-orc/src/main/resources/META-INF/services/NOTICE
##########
@@ -1,4 +1,4 @@
-flink-orc
Review comment:
The location of this file is wrong. It needs to be in the META-INF
folder, not the services folder.
##########
File path:
flink-formats/flink-sql-parquet/src/main/resources/META-INF/services/NOTICE
##########
@@ -1,4 +1,4 @@
-flink-parquet
Review comment:
same issue
##########
File path: flink-formats/flink-sql-orc/pom.xml
##########
@@ -0,0 +1,92 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
I'm not sure if it is necessary to create new modules just to create the
fat jar.
Afaik, you can use the maven shade plugin to create a new jar. I guess the
`<finalName>` or `<outputFile>` parameter will be of help for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
