carp84 commented on pull request #12514: URL: https://github.com/apache/flink/pull/12514#issuecomment-643363267
> Forwarding my comments from the #12529 PR (the 1.11.0 port of this PR) > > I would suggest that we avoid "parameterized" tests for this. I think this is not a configuration option that we need to cross test all with all unit tests. This adds a huge amount of test runtime. > > Instead I would add tests that are very targeted, for the behavior that is affected by this (range iterators, like in MapState and in Timers). @StephanEwen It seems the latest changes here have followed the suggestions and extracted the test cases into a new `RocksDBStateMisuseOptionTest` class. Would you mind to take another look? Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
