yun-wang commented on a change in pull request #12619:
URL: https://github.com/apache/flink/pull/12619#discussion_r439613236
##########
File path:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkFunction.java
##########
@@ -65,6 +65,11 @@
*/
default void open() {}
+ /**
+ * Tear-down method for the function. It is called when the sink closes.
+ */
+ default void close () throws Exception {}
Review comment:
I can update `open` to `default void open() throws Exception {}` real
quick. It's a backward compatible change and should have no user impact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
