tillrohrmann commented on a change in pull request #12620:
URL: https://github.com/apache/flink/pull/12620#discussion_r439726113
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -404,13 +404,17 @@ private void stopResourceManagerServices() throws
Exception {
final WorkerRegistration<WorkerType>
workerTypeWorkerRegistration = taskExecutors.get(taskManagerResourceId);
if
(workerTypeWorkerRegistration.getInstanceID().equals(taskManagerRegistrationId))
{
-
slotManager.registerTaskManager(workerTypeWorkerRegistration, slotReport);
+
registerTaskManagerAtSlotManager(workerTypeWorkerRegistration, slotReport);
Review comment:
I think we might call `onTaskManagerRegistration` multiple times for the
same `TM` registration if `registerTaskManager` does not tell use whether it is
a new registration or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
