StephanEwen commented on pull request #12514: URL: https://github.com/apache/flink/pull/12514#issuecomment-643677068
All in all, looks good to me. One thing that surprised me a bit was adding the `ReadOptions` and `WriteOptions` to the `PredefinedOptions`. I always thought that the `PredefinedOptions` are a "shortcut" for users to configure common options. These read options and write options are not configurable options in the end, but "must-have" options that users cannot change (similar to the RocksDB option "create if not exists") so I am a bit confused about them being added to a class that managed user-defined options. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
