rmetzger commented on a change in pull request #12653:
URL: https://github.com/apache/flink/pull/12653#discussion_r440112339



##########
File path: flink-end-to-end-tests/test-scripts/test-runner-common.sh
##########
@@ -105,6 +107,13 @@ function post_test_validation {
     fi
 }
 
+function log_environment_info {
+    echo "Jps"
+    jps

Review comment:
       If you are going with `jps`, I would use `jps -v`, as it also lists the 
arguments (which sometimes include the log directory, which might help 
identifiying where the process is coming from).
   
   Secondly, I would also run `pstree`. Some tests (k8s, dockerized ...) are 
running non-JVM processes.

##########
File path: flink-end-to-end-tests/test-scripts/test-runner-common.sh
##########
@@ -93,7 +93,9 @@ function post_test_validation {
 
     if [[ ${exit_code} == 0 ]]; then
         cleanup
+        log_environment_info
     else
+        log_environment_info

Review comment:
       Why aren't you invoking this function outside of the `if` statement, if 
it applies to both cases?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to