StephanEwen opened a new pull request #12662:
URL: https://github.com/apache/flink/pull/12662


   ## Purpose of the change / Change log
   
   This changes the name of the file for the TaskManager workers from *slaves* 
to *workers*.
   
   **Note:** This change breaks setups that currently use the *slaves* file, 
because it only checks for the *workers* file.
   That was done under the rationale that production setups should not really 
rely on that file (rather use Yarn, Kubernetes, custom init.d scripts) because 
this never restarts failed TaskManagers.
   The advantage of not implementing the "backwards compatibility" here is to 
get rid of the *"slaves"* term in the scripts right away.
   
   ## Verifying this change
   
   This change can be verified by building Flink and starting/stopping a 
standalone session via `bin/start-cluster.sh` / `bin/stop-cluster.sh`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to