leonardBang commented on a change in pull request #12630:
URL: https://github.com/apache/flink/pull/12630#discussion_r440563526
##########
File path: docs/dev/table/streaming/temporal_tables.md
##########
@@ -260,32 +260,43 @@ See also the page about [joins for continuous
queries](joins.html) for more info
{% highlight java %}
// Get the stream and table environments.
StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
-StreamTableEnvironment tEnv = TableEnvironment.getTableEnvironment(env);
-
-// Create an HBaseTableSource as a temporal table which implements
LookableTableSource
-// In the real setup, you should replace this with your own table.
-HBaseTableSource rates = new HBaseTableSource(conf, "Rates");
-rates.setRowKey("currency", String.class); // currency as the primary key
-rates.addColumn("fam1", "rate", Double.class);
-
-// register the temporal table into environment, then we can query it in sql
-tEnv.registerTableSource("Rates", rates);
+EnvironmentSettings settings =
EnvironmentSettings.newInstance().useBlinkPlanner().inStreamingMode().build();
+StreamTableEnvironment tEnv = StreamTableEnvironment.create(env, settings);
+// or TableEnvironment tEnv = TableEnvironment.create(settings);
+
+// Define an HBase table with DDL, then we can use it as a temporal table in
sql
Review comment:
The pronounce of 'H' in 'HBase' is 'eɪtʃ', the first sound is vowel, so
we should use 'an HBase'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
