zhijiangW commented on a change in pull request #12664:
URL: https://github.com/apache/flink/pull/12664#discussion_r440569809
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorTest.java
##########
@@ -218,6 +230,67 @@ public void testNotifyCheckpointAbortedBeforeAsyncPhase()
throws Exception {
assertEquals(0,
subtaskCheckpointCoordinator.getAsyncCheckpointRunnableSize());
}
+ @Test
+ public void
testDownstreamReceiveCancelCheckpointMarkerOnUpstreamAbortedInSyncPhase()
throws Exception {
+ final OneInputStreamTaskTestHarness<String, String> testHarness
=
+ new OneInputStreamTaskTestHarness<>(
+ OneInputStreamTask::new,
+ 1, 1,
+ BasicTypeInfo.STRING_TYPE_INFO,
+ BasicTypeInfo.STRING_TYPE_INFO);
+
+ testHarness.setupOutputForSingletonOperatorChain();
+ StreamConfig streamConfig = testHarness.getStreamConfig();
+ streamConfig.setStreamOperator(new MapOperator());
+
+ testHarness.invoke();
+ testHarness.waitForTaskRunning();
+
+ TestTaskStateManager stateManager = new TestTaskStateManager();
+ MockEnvironment mockEnvironment =
MockEnvironment.builder().setTaskStateManager(stateManager).build();
+ SubtaskCheckpointCoordinatorImpl subtaskCheckpointCoordinator =
(SubtaskCheckpointCoordinatorImpl) new MockSubtaskCheckpointCoordinatorBuilder()
+ .setEnvironment(mockEnvironment)
+ .setUnalignedCheckpointEnabled(true)
Review comment:
no need for unaligned mode, the previous deadlock was actually found in
alignment mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
