tillrohrmann commented on a change in pull request #11322:
URL: https://github.com/apache/flink/pull/11322#discussion_r440679410
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
##########
@@ -99,6 +99,18 @@ public static void setupYarnClassPath(Configuration conf,
Map<String, String> ap
}
}
+ /**
+ * Returns the Path where the YARN application files should be uploaded
to.
+ *
+ * @param homedir
+ * remote home directory base (will be extended)
+ * @param appId
+ * application ID
+ */
+ public static Path getYarnFilesDir(final Path homedir, final String
appId) {
Review comment:
I think we can tighten the contract a bit and say that `appId` must be
of type `ApplicationId`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
