zentol commented on a change in pull request #12674:
URL: https://github.com/apache/flink/pull/12674#discussion_r440716985
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/main/java/org/apache/flink/tests/util/kafka/LocalStandaloneKafkaResource.java
##########
@@ -251,7 +251,11 @@ public void sendMessages(String topic, String... messages)
throws IOException {
"--broker-list",
KAFKA_ADDRESS,
"--topic",
- topic)) {
+ topic,
+ "--property",
+ "parse.key=true",
+ "--property",
+ "key.separator=\t")) {
Review comment:
baking this directly into this method smells a bit. It is not obvious to
the user that this format is expected. What happens if no key is provided, like
in the SQLClientKafkaITCase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
