JingsongLi commented on a change in pull request #12657:
URL: https://github.com/apache/flink/pull/12657#discussion_r440718820
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -167,6 +186,18 @@ private static void processStream(final InputStream
stream, final Consumer<Strin
).start();
}
+ private static void processOutputStream(final OutputStream stream,
final List<String> inputs) {
+ new Thread(() -> {
+ try (PrintStream printStream = new PrintStream(stream,
true, StandardCharsets.UTF_8.name())) {
Review comment:
Actually, try with resource will close this output put stream, and in
this way, will close process.
I think you should create a better method name for this, and add comments to
explain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
