[
https://issues.apache.org/jira/browse/FLINK-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130217#comment-15130217
]
ASF GitHub Bot commented on FLINK-2935:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1500#discussion_r51705046
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/FlinkYarnSessionCli.java ---
@@ -417,13 +417,9 @@ public int run(String[] args) {
String jobManagerAddress =
yarnCluster.getJobManagerAddress().getAddress().getHostAddress() + ":" +
yarnCluster.getJobManagerAddress().getPort();
System.out.println("Flink JobManager is now running on
" + jobManagerAddress);
System.out.println("JobManager Web Interface: " +
yarnCluster.getWebInterfaceURL());
- // file that we write into the conf/ dir containing the
jobManager address and the dop.
-
- String defaultPropertiesFileLocation =
System.getProperty("java.io.tmpdir");
- String currentUser = System.getProperty("user.name");
- String propertiesFileLocation =
yarnCluster.getFlinkConfiguration().getString(ConfigConstants.YARN_PROPERTIES_FILE_LOCATION,
defaultPropertiesFileLocation);
- File yarnPropertiesFile = new
File(propertiesFileLocation + File.separator + CliFrontend.YARN_PROPERTIES_FILE
+ currentUser);
+ // file that we write into the conf/ dir containing the
jobManager address and the dop.
+ File yarnPropertiesFile = new
File(getYarnPropertiesLocation(yarnCluster.getFlinkConfiguration()));
--- End diff --
The yarnPropertiesFile path construction is also done in `CliFrontend:173`.
This should also be changed to use the new `getYarnPropertiesLocation` method.
Maybe moving this method to `CliFrontend` makes sense.
> Allow scala shell to read yarn properties
> -----------------------------------------
>
> Key: FLINK-2935
> URL: https://issues.apache.org/jira/browse/FLINK-2935
> Project: Flink
> Issue Type: Improvement
> Components: Scala Shell
> Affects Versions: 0.9.1
> Reporter: Johannes
> Assignee: Chiwan Park
> Priority: Minor
> Labels: easyfix
>
> Currently the deployment of flink via yarn and the scala shell are not linked.
> When deploying a yarn session the file
> bq. org.apache.flink.client.CliFrontend
> creates a
> bq. .yarn-properties-$username
> file with the connection properties.
> There should be a way to have the scala shell automatically read this file if
> wanted as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
