StephanEwen commented on a change in pull request #12683:
URL: https://github.com/apache/flink/pull/12683#discussion_r440885165
##########
File path: flink-python/pyflink/datastream/state_backend.py
##########
@@ -637,11 +637,11 @@ def set_options(self, options_factory_class_name):
The options factory must have a
default constructor.
"""
gateway = get_gateway()
- JOptionsFactory =
gateway.jvm.org.apache.flink.contrib.streaming.state.OptionsFactory
+ JOptionsFactory =
gateway.jvm.org.apache.flink.contrib.streaming.state.RocksDBOptionsFactory
j_options_factory_clz = load_java_class(options_factory_class_name)
if not
get_java_class(JOptionsFactory).isAssignableFrom(j_options_factory_clz):
- raise ValueError("The input class not implements OptionsFactory.")
-
self._j_rocks_db_state_backend.setOptions(j_options_factory_clz.newInstance())
+ raise ValueError("The input class not implements
RocksDBOptionsFactory.")
Review comment:
This should be "The input class does not implement RocksDBOptionsFactory"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
