[
https://issues.apache.org/jira/browse/FLINK-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130245#comment-15130245
]
ASF GitHub Bot commented on FLINK-3128:
---------------------------------------
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1565#issuecomment-179172028
Really good work @f-sander. Good test coverage and good code documentation.
It would be good to add some online documentation for this algorithm (see
flink/docs/libraries/ml).
I had a comment concerning scalability. I fear that with the current
implementation, the algorithm is effectively bound by the capacities of a
single machine. Especially sorting the data on the heap is destined to quickly
crash the system. I'm not an expert on isotonic regression but it would be nice
to get rid of the operator which collects all the input data in a single task
to sort them.
I also haven't gone through the math details yet. Will do, once the
scalability issue is fixed.
> Add Isotonic Regression To ML Library
> -------------------------------------
>
> Key: FLINK-3128
> URL: https://issues.apache.org/jira/browse/FLINK-3128
> Project: Flink
> Issue Type: New Feature
> Components: Machine Learning Library
> Reporter: Fridtjof Sander
> Assignee: Fridtjof Sander
> Priority: Minor
>
> Isotonic Regression fits a monotonically increasing function (also called
> isotonic function) to a plane of datapoints.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
