lirui-apache commented on pull request #12682:
URL: https://github.com/apache/flink/pull/12682#issuecomment-645136144


   > Looking through these checks, I am wondering if we have a set of 
unnecessary dependencies here. For example Kryo, minlog, objenises are all 
dependencies of flink-core already, so we should not require them here.
   
   I agree there can be duplicated dependencies since hive-exec is a huge uber 
jar. But I don't know a good method to find all such dependencies. Perhaps I 
should just compare the `flink-sql-connector-hive` and `flink-dist` jars to 
determine that?
   
   As for the example of Kryo, hive-exec has relocated it so we cannot reuse 
what's already included in Flink.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to