zhuzhurk commented on a change in pull request #12278:
URL: https://github.com/apache/flink/pull/12278#discussion_r441430620



##########
File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolImplTest.java
##########
@@ -738,6 +740,95 @@ public void testCalculationOfTaskExecutorUtilization() 
throws Exception {
                }
        }
 
+       @Test
+       public void testOrphanedAllocationCanBeRemapped() throws Exception {
+               try (SlotPoolImpl slotPool = createSlotPoolImpl()) {
+                       final List<AllocationID> allocationIds = new 
ArrayList<>();
+                       resourceManagerGateway.setRequestSlotConsumer(
+                               slotRequest -> 
allocationIds.add(slotRequest.getAllocationId()));
+
+                       final List<AllocationID> canceledAllocations = new 
ArrayList<>();
+                       
resourceManagerGateway.setCancelSlotConsumer(canceledAllocations::add);

Review comment:
       Maybe later along with the rework of all SlotPool tests? Because 
resourceManagerGateway is shared between all cases and it's better to have an 
overview of the usages.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to