wuchong commented on a change in pull request #12687: URL: https://github.com/apache/flink/pull/12687#discussion_r441431482
########## File path: flink-connectors/flink-sql-connector-hbase/src/main/resources/META-INF/NOTICE ########## @@ -0,0 +1,27 @@ +flink-sql-connector-hbase +Copyright 2014-2020 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt) + +- commons-codec:commons-codec:1.10 +- commons-configuration:commons-configuration:1.7 +- commons-lang:commons-lang:2.6 +- commons-logging:commons-logging:1.1.3 +- com.google.guava:guava:12.0.1 +- com.yammer.metrics:metrics-core:2.2.0 +- io.netty:netty-all:4.1.44.Final +- org.apache.hbase:hbase-common:1.4.3 +- org.apache.hbase:hbase-protocol:1.4.3 +- org.apache.hbase:hbase-procedure:1.4.3 +- org.apache.hbase:hbase-client:1.4.3 +- org.apache.hbase:hbase-prefix-tree:1.4.3 +- org.apache.htrace:htrace-core:3.1.0-incubating Review comment: htrace-core bundles several dependencies but doesn't have a proper NOTICE. Maybe we should list the dependencies: ``` htrace-core From: 'FasterXML' (http://fasterxml.com/) - Jackson-annotations (http://wiki.fasterxml.com/JacksonHome) com.fasterxml.jackson.core:jackson-annotations:bundle:2.4.0 License: The Apache Software License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) - Jackson-core (http://wiki.fasterxml.com/JacksonHome) com.fasterxml.jackson.core:jackson-core:bundle:2.4.0 License: The Apache Software License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) - jackson-databind (http://wiki.fasterxml.com/JacksonHome) com.fasterxml.jackson.core:jackson-databind:bundle:2.4.0 License: The Apache Software License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) From: 'The Apache Software Foundation' (http://www.apache.org/) - Commons Logging (http://commons.apache.org/logging) commons-logging:commons-logging:jar:1.1.1 License: The Apache Software License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) ``` The `commons-logging` is a different version. ########## File path: flink-connectors/flink-sql-connector-hbase/src/main/resources/META-INF/NOTICE ########## @@ -0,0 +1,27 @@ +flink-sql-connector-hbase +Copyright 2014-2020 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt) + +- commons-codec:commons-codec:1.10 +- commons-configuration:commons-configuration:1.7 +- commons-lang:commons-lang:2.6 +- commons-logging:commons-logging:1.1.3 +- com.google.guava:guava:12.0.1 +- com.yammer.metrics:metrics-core:2.2.0 +- io.netty:netty-all:4.1.44.Final Review comment: Shall we list all the netty dependencies if `netty-all` is included? ``` io.netty:netty-codec-smtp:4.1.44.Final io.netty:netty-transport-native-epoll:4.1.44.Final io.netty:netty-codec-redis:4.1.44.Final io.netty:netty-resolver-dns:4.1.44.Final io.netty:netty-codec-dns:4.1.44.Final io.netty:netty-resolver-dns-native-macos:4.1.44.Final io.netty:netty-codec-mqtt:4.1.44.Final io.netty:netty-codec-http2:4.1.44.Final io.netty:netty-transport-native-unix-common:4.1.44.Final io.netty:netty-transport-sctp:4.1.44.Final io.netty:netty-transport-native-epoll:4.1.44.Final io.netty:netty-codec-http:4.1.44.Final io.netty:netty-transport-udt:4.1.44.Final io.netty:netty-handler-proxy:4.1.44.Final io.netty:netty-resolver:4.1.44.Final io.netty:netty-common:4.1.44.Final io.netty:netty-codec-xml:4.1.44.Final io.netty:netty-transport:4.1.44.Final io.netty:netty-codec:4.1.44.Final io.netty:netty-codec-socks:4.1.44.Final io.netty:netty-codec-stomp:4.1.44.Final io.netty:netty-buffer:4.1.44.Final io.netty:netty-transport-rxtx:4.1.44.Final io.netty:netty-codec-haproxy:4.1.44.Final io.netty:netty-codec-haproxy:4.1.44.Final io.netty:netty-tcnative:2.0.28.Final io.netty:netty-transport-native-kqueue:4.1.44.Final io.netty:netty-handler:4.1.44.Final io.netty:netty-codec-memcache:4.1.44.Final ``` I'm not sure about this, but as there are no other 3rd party dependencies in `netty-all`, maybe it's fine just include `netty-all`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
