tillrohrmann commented on a change in pull request #12670:
URL: https://github.com/apache/flink/pull/12670#discussion_r441481638
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -582,7 +583,18 @@ private void
startTriggeringCheckpoint(CheckpointTriggerRequest request) {
return null;
},
- timer));
+ timer)
+ .exceptionally(error -> {
+ isTriggering = false;
+ if (!isShutdown()) {
+
ExceptionUtils.rethrow(error);
+ } else if (error instanceof
RejectedExecutionException) {
+ LOG.debug("Execution
rejected during shutdown");
+ } else {
+ LOG.warn("Error
encountered during shutdown", error);
+ }
Review comment:
In case of a shut down I would argue that exceptions can occur if the
concurrent tasks are not properly stopped before. But it does not hurt to keep
in on `warn` given that it should not really occur.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
