[
https://issues.apache.org/jira/browse/FLINK-18236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138502#comment-17138502
]
Robert Metzger commented on FLINK-18236:
----------------------------------------
Thanks a lot for your contribution. Please check the contribution guide in
Flink: https://flink.apache.org/contributing/contribute-code.html
We usually ask contributors to first get a confirmation in JIRA (by being
assigned to the ticket) for their contribution, to make sure the contribution
is relevant.
In this case, I have the feeling that the contribution is not based on an
actual failure, rather on "searching through the code for a contribution
opportunity"
Quote from the contribution guide:
{quote}Is this a contribution just for the sake of getting a commit in an open
source project (fixing typos, style changes merely for taste reasons){quote}
Such changes have the potential to be ignored because the take away very
limited contributor capacities. If you want to work on something that has a
chance to get some review attention, I would recommend working on tickets
labelled with the {{starter}} tag. Alternatively, flink-statefun is currently
looking to add support for more language SDKs.
I will now merge the PR because it does not break anything, needs no review,
and will make the error reporting a tiny bit better.
> flink elasticsearch IT test ElasticsearchSinkTestBase.runElasticsearchSink*
> verify it not right
> -----------------------------------------------------------------------------------------------
>
> Key: FLINK-18236
> URL: https://issues.apache.org/jira/browse/FLINK-18236
> Project: Flink
> Issue Type: Bug
> Components: Connectors / ElasticSearch
> Affects Versions: 1.10.0
> Reporter: jackylau
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0, 1.12.0
>
>
> we can see there are diffirent tests
> runElasticsearchSinkTest
> runElasticsearchSinkCborTest
> runElasticsearchSinkSmileTest
> runElasticSearchSinkTest
> etc.
> And use SourceSinkDataTestKit.verifyProducedSinkData(client, index) to ensure
> the correctness of results. But all of them use the same index.
> That is to say, if the second unit test sink doesn't send successfully. they
> are also equal when use verifyProducedSinkData
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
