danmagyar commented on pull request #12636: URL: https://github.com/apache/flink/pull/12636#issuecomment-645474906
I've updated the commit to according to your insights @tillrohrmann, @zentol. A few minor decisions I'd like to highlight and draw your attention to that don't address your requests directly in case you'd like to see it changed: * [Renamed](https://github.com/apache/flink/compare/c91fac7a9ceaae8605e7146cdeffa00e2a15e187..0c85b2b7c17d75189f1ffdf264e893d94da88cd2#diff-ed2f12d42964612046a16b3ef5aa7ffeR162) `processArchiveDeletion` to `processExpiredArchiveDeletion` so I could introduce `processBeyondLimitArchiveDeletion` in a clean and consistent way to disable removing these archives if configured to `-1` or negative. This changed seemed minor enough to avoid splitting it into a different commit. * [Kept the behavior of removing all archives](https://github.com/apache/flink/compare/c91fac7a9ceaae8605e7146cdeffa00e2a15e187..0c85b2b7c17d75189f1ffdf264e893d94da88cd2#diff-ed2f12d42964612046a16b3ef5aa7ffeR186) if `historyserver.archive.retained-jobs` is set to 0, . * Didn't introduce boundary testing for the config (covering values of 0, -1, etc.) as they seemed to not worth the additional time it takes for the tests to start a new history server. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
