[
https://issues.apache.org/jira/browse/FLINK-18348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138691#comment-17138691
]
Piotr Nowojski edited comment on FLINK-18348 at 6/17/20, 5:58 PM:
------------------------------------------------------------------
. I think this change was caused by FLINK-16536 via adding this method:
{code:java}
private void internalRequestPartitions() {
for (InputChannel inputChannel : inputChannels.values()) {
try {
inputChannel.requestSubpartition(consumedSubpartitionIndex);
} catch (Throwable t) {
inputChannel.setError(t);
return;
}
}
}
{code}
-Upgrading to blocker-. Upgrading to critical. I think this is not a blocker,
as this is just hiding some connection issue with this
{{IllegalStateException}}. [~zjwang], what do you think?
was (Author: pnowojski):
Upgrading to blocker. I think this change was caused by FLINK-16536 via adding
this method:
{code:java}
private void internalRequestPartitions() {
for (InputChannel inputChannel : inputChannels.values()) {
try {
inputChannel.requestSubpartition(consumedSubpartitionIndex);
} catch (Throwable t) {
inputChannel.setError(t);
return;
}
}
}
{code}
CC [~zjwang]
> RemoteInputChannel should checkError before checking partitionRequestClient
> ---------------------------------------------------------------------------
>
> Key: FLINK-18348
> URL: https://issues.apache.org/jira/browse/FLINK-18348
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Network
> Affects Versions: 1.10.1, 1.11.0, 1.12.0
> Reporter: Jiayi Liao
> Priority: Critical
> Fix For: 1.11.0
>
>
> The error will be set and \{{partitionRequestClient}} will be a null value if
> a remote channel fails to request the partition at the beginning. And the
> task will fail
> [here|https://github.com/apache/flink/blob/2150533ac0b2a6cc00238041853bbb6ebf22cee9/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java#L172]
> when the task thread trying to fetch data from channels.
> And then we get error:
> {code:java}
> java.lang.IllegalStateException: Queried for a buffer before requesting a
> queue.
> at
> org.apache.flink.util.Preconditions.checkState(Preconditions.java:195)
> ~[flink-dist_2.11-1.11-SNAPSHOT.jar:1.11-SNAPSHOT]
> at
> org.apache.flink.runtime.io.network.partition.consumer.RemoteInputChannel.getNextBuffer(RemoteInputChannel.java:172)
> ~[flink-dist_2.11-1.11-SNAPSHOT.jar:1.11-SNAPSHOT]
> at
> org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate.waitAndGetNextData(SingleInputGate.java:637)
> ~[flink-dist_2.11-1.11-SNAPSHOT.jar:1.11-SNAPSHOT]
> at
> org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate.getNextBufferOrEvent(SingleInputGate.java:615)
> ~[flink-dist_2.11-1.11-SNAPSHOT.jar:1.11-SNAPSHOT]
> at
> org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate.getNext(SingleInputGate.java:598)
> ~[flink-dist_2.11-1.11-SNAPSHOT.jar:1.11-SNAPSHOT]
> {code}
> But the root cause is the {{PartitionConnectionException}} we set when
> requesting the partition.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
