rkhachatryan opened a new pull request #12700:
URL: https://github.com/apache/flink/pull/12700


   **This PR is WIP**
   
   ## What is the purpose of the change
   
   Wait for the `LegacySourceFunctionThread` to finish when cancelling the task.
   This prevents premature freeing of resources, particularly LibraryCache.
   
   ## Brief change log
   
     - Join `sourceThread` in `SourceStreamTask.cancelTask`
     - Add wait timeout to have time for cleanup - this is quite invasive but 
independent change - so I extracted this to a separate commit
   
   
   ## Verifying this change
   
   TBD. 
   Unit test seems to be not enough; full test is non-trivial;
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to