rmetzger commented on a change in pull request #12689: URL: https://github.com/apache/flink/pull/12689#discussion_r442042637
########## File path: flink-connectors/flink-sql-connector-hive-3.1.2/src/main/resources/META-INF/NOTICE ########## @@ -8,3 +8,51 @@ This project bundles the following dependencies under the Apache Software Licens - org.apache.hive:hive-exec:3.1.2 - org.apache.thrift:libfb303:0.9.3 + +The bundled Apache Hive org.apache.hive:hive-exec dependency bundles the following dependencies under +the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) + +- com.esotericsoftware:kryo-shaded:3.0.3 +- com.esotericsoftware:minlog:1.3.0 +- com.esotericsoftware:reflectasm:1.10.1 +- com.google.guava:guava:19.0 +- com.googlecode.javaewah:JavaEWAH:0.3.2 +- com.tdunning:json:1.8 +- commons-lang:commons-lang:2.6 +- io.airlift:aircompressor:0.10 +- javax.jdo:jdo-api:3.0.1 +- joda-time:joda-time:2.9.9 +- net.sf.opencsv:opencsv:2.3 +- org.apache.avro:avro-mapred:1.8.2 +- org.apache.avro:avro:1.8.2 +- org.apache.commons:commons-lang3:3.3.2 +- org.apache.hive.shims:hive-shims-0.23:3.1.2 +- org.apache.hive.shims:hive-shims-common:3.1.2 +- org.apache.hive:hive-common:3.1.2 +- org.apache.hive:hive-llap-client:3.1.2 +- org.apache.hive:hive-llap-common:3.1.2 +- org.apache.hive:hive-metastore:3.1.2 +- org.apache.hive:hive-serde:3.1.2 +- org.apache.hive:hive-service-rpc:3.1.2 +- org.apache.hive:hive-spark-client:3.1.2 +- org.apache.hive:hive-standalone-metastore:3.1.2 +- org.apache.hive:hive-storage-api:3.1.2 +- org.apache.orc:orc-core:1.5.6 +- org.apache.orc:orc-shims:1.5.6 +- org.apache.orc:orc-tools:1.5.6 +- org.apache.parquet:parquet-hadoop-bundle:1.10.0 +- org.apache.parquet:parquet-jackson:1.10.0 +- org.apache.thrift:libthrift:0.9.3 +- org.codehaus.jackson:jackson-core-asl:2.9.5 +- org.codehaus.jackson:jackson-mapper-asl:2.9.5 +- org.objenesis:objenesis:2.1 + +The bundled Apache Hive org.apache.hive:hive-exec dependency bundles the following dependencies under the BSD license. +See bundled license files for details. + +- com.esotericsoftware:kryo-shaded:3.0.3 +- com.esotericsoftware:minlog:1.3.0 +- com.esotericsoftware:reflectasm:1.10.1 Review comment: where did you find this dependency listed? When I compiled hive 3.1.2, it wasn't listed by the shade plugin. However. there are indeed reflectasm classes in the final binary. ########## File path: flink-connectors/flink-sql-connector-hive-2.3.6/src/main/resources/META-INF/NOTICE ########## @@ -7,3 +7,51 @@ The Apache Software Foundation (http://www.apache.org/). This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt) - org.apache.hive:hive-exec:2.3.6 + +The bundled Apache Hive org.apache.hive:hive-exec dependency bundles the following dependencies under +the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) + +- com.google.guava:guava:14.0.1 +- com.googlecode.javaewah:JavaEWAH:0.3.2 +- com.tdunning:json:1.14 Review comment: My maven-shade-plugin run said ``` [INFO] Including com.tdunning:json:jar:1.8 in the shaded jar. ``` ########## File path: flink-connectors/flink-sql-connector-hive-3.1.2/src/main/resources/META-INF/NOTICE ########## @@ -8,3 +8,51 @@ This project bundles the following dependencies under the Apache Software Licens - org.apache.hive:hive-exec:3.1.2 - org.apache.thrift:libfb303:0.9.3 + +The bundled Apache Hive org.apache.hive:hive-exec dependency bundles the following dependencies under +the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) + +- com.esotericsoftware:kryo-shaded:3.0.3 +- com.esotericsoftware:minlog:1.3.0 +- com.esotericsoftware:reflectasm:1.10.1 +- com.google.guava:guava:19.0 +- com.googlecode.javaewah:JavaEWAH:0.3.2 +- com.tdunning:json:1.8 +- commons-lang:commons-lang:2.6 +- io.airlift:aircompressor:0.10 +- javax.jdo:jdo-api:3.0.1 +- joda-time:joda-time:2.9.9 +- net.sf.opencsv:opencsv:2.3 +- org.apache.avro:avro-mapred:1.8.2 +- org.apache.avro:avro:1.8.2 +- org.apache.commons:commons-lang3:3.3.2 +- org.apache.hive.shims:hive-shims-0.23:3.1.2 +- org.apache.hive.shims:hive-shims-common:3.1.2 +- org.apache.hive:hive-common:3.1.2 +- org.apache.hive:hive-llap-client:3.1.2 +- org.apache.hive:hive-llap-common:3.1.2 +- org.apache.hive:hive-metastore:3.1.2 +- org.apache.hive:hive-serde:3.1.2 +- org.apache.hive:hive-service-rpc:3.1.2 +- org.apache.hive:hive-spark-client:3.1.2 +- org.apache.hive:hive-standalone-metastore:3.1.2 +- org.apache.hive:hive-storage-api:3.1.2 Review comment: I don't know what's going on with my maven ``` [INFO] Including org.apache.hive:hive-storage-api:jar:2.7.0 in the shaded jar. ``` ########## File path: flink-connectors/flink-sql-connector-hive-2.3.6/src/main/resources/META-INF/NOTICE ########## @@ -7,3 +7,51 @@ The Apache Software Foundation (http://www.apache.org/). This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt) - org.apache.hive:hive-exec:2.3.6 + +The bundled Apache Hive org.apache.hive:hive-exec dependency bundles the following dependencies under +the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) + +- com.google.guava:guava:14.0.1 +- com.googlecode.javaewah:JavaEWAH:0.3.2 +- com.tdunning:json:1.14 +- commons-lang:commons-lang:2.6 +- io.airlift:aircompressor:0.8 +- javax.jdo:jdo-api:3.0.1 +- joda-time:joda-time:2.8.1 +- net.sf.opencsv:opencsv:2.3 +- org.apache.avro:avro-mapred:1.7.7 +- org.apache.avro:avro:1.7.7 +- org.apache.commons:commons-lang3:3.1 +- org.apache.hive.shims:hive-shims-0.23:2.3.6 +- org.apache.hive.shims:hive-shims-common:2.3.6 +- org.apache.hive:hive-common:2.3.6 +- org.apache.hive:hive-llap-client:2.3.6 +- org.apache.hive:hive-llap-common:2.3.6 +- org.apache.hive:hive-metastore:2.3.6 +- org.apache.hive:hive-serde:2.3.6 +- org.apache.hive:hive-service-rpc:2.3.6 +- org.apache.hive:hive-storage-api:2.3.6 Review comment: For some weird reason, my maven-shade plugin logged this ``` [INFO] Including org.apache.hive:hive-storage-api:jar:2.4.0 in the shaded jar. ``` ########## File path: flink-connectors/flink-sql-connector-hive-3.1.2/src/main/resources/META-INF/NOTICE ########## @@ -8,3 +8,51 @@ This project bundles the following dependencies under the Apache Software Licens - org.apache.hive:hive-exec:3.1.2 - org.apache.thrift:libfb303:0.9.3 + +The bundled Apache Hive org.apache.hive:hive-exec dependency bundles the following dependencies under +the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) + +- com.esotericsoftware:kryo-shaded:3.0.3 +- com.esotericsoftware:minlog:1.3.0 +- com.esotericsoftware:reflectasm:1.10.1 Review comment: com.esotericsoftware:reflectasm is listed twice, and not ASL2.0 licensed. ########## File path: flink-connectors/flink-sql-connector-hive-3.1.2/src/main/resources/META-INF/NOTICE ########## @@ -8,3 +8,51 @@ This project bundles the following dependencies under the Apache Software Licens - org.apache.hive:hive-exec:3.1.2 - org.apache.thrift:libfb303:0.9.3 + +The bundled Apache Hive org.apache.hive:hive-exec dependency bundles the following dependencies under +the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) + +- com.esotericsoftware:kryo-shaded:3.0.3 +- com.esotericsoftware:minlog:1.3.0 +- com.esotericsoftware:reflectasm:1.10.1 +- com.google.guava:guava:19.0 +- com.googlecode.javaewah:JavaEWAH:0.3.2 +- com.tdunning:json:1.8 +- commons-lang:commons-lang:2.6 +- io.airlift:aircompressor:0.10 +- javax.jdo:jdo-api:3.0.1 +- joda-time:joda-time:2.9.9 +- net.sf.opencsv:opencsv:2.3 +- org.apache.avro:avro-mapred:1.8.2 Review comment: [INFO] Including org.apache.avro:avro-mapred:jar:hadoop2:1.7.7 in the shaded jar. ########## File path: flink-connectors/flink-sql-connector-hive-3.1.2/src/main/resources/META-INF/NOTICE ########## @@ -8,3 +8,51 @@ This project bundles the following dependencies under the Apache Software Licens - org.apache.hive:hive-exec:3.1.2 - org.apache.thrift:libfb303:0.9.3 + +The bundled Apache Hive org.apache.hive:hive-exec dependency bundles the following dependencies under +the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) + +- com.esotericsoftware:kryo-shaded:3.0.3 +- com.esotericsoftware:minlog:1.3.0 +- com.esotericsoftware:reflectasm:1.10.1 +- com.google.guava:guava:19.0 +- com.googlecode.javaewah:JavaEWAH:0.3.2 +- com.tdunning:json:1.8 +- commons-lang:commons-lang:2.6 +- io.airlift:aircompressor:0.10 +- javax.jdo:jdo-api:3.0.1 +- joda-time:joda-time:2.9.9 +- net.sf.opencsv:opencsv:2.3 +- org.apache.avro:avro-mapred:1.8.2 +- org.apache.avro:avro:1.8.2 +- org.apache.commons:commons-lang3:3.3.2 +- org.apache.hive.shims:hive-shims-0.23:3.1.2 +- org.apache.hive.shims:hive-shims-common:3.1.2 +- org.apache.hive:hive-common:3.1.2 +- org.apache.hive:hive-llap-client:3.1.2 +- org.apache.hive:hive-llap-common:3.1.2 +- org.apache.hive:hive-metastore:3.1.2 +- org.apache.hive:hive-serde:3.1.2 +- org.apache.hive:hive-service-rpc:3.1.2 +- org.apache.hive:hive-spark-client:3.1.2 +- org.apache.hive:hive-standalone-metastore:3.1.2 +- org.apache.hive:hive-storage-api:3.1.2 +- org.apache.orc:orc-core:1.5.6 +- org.apache.orc:orc-shims:1.5.6 +- org.apache.orc:orc-tools:1.5.6 +- org.apache.parquet:parquet-hadoop-bundle:1.10.0 +- org.apache.parquet:parquet-jackson:1.10.0 +- org.apache.thrift:libthrift:0.9.3 +- org.codehaus.jackson:jackson-core-asl:2.9.5 +- org.codehaus.jackson:jackson-mapper-asl:2.9.5 Review comment: ``` [INFO] Including org.codehaus.jackson:jackson-core-asl:jar:1.9.13 in the shaded jar. [INFO] Including org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13 in the shaded jar. ``` ########## File path: flink-connectors/flink-sql-connector-hive-3.1.2/src/main/resources/META-INF/NOTICE ########## @@ -8,3 +8,51 @@ This project bundles the following dependencies under the Apache Software Licens - org.apache.hive:hive-exec:3.1.2 - org.apache.thrift:libfb303:0.9.3 + +The bundled Apache Hive org.apache.hive:hive-exec dependency bundles the following dependencies under +the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) + +- com.esotericsoftware:kryo-shaded:3.0.3 +- com.esotericsoftware:minlog:1.3.0 +- com.esotericsoftware:reflectasm:1.10.1 +- com.google.guava:guava:19.0 +- com.googlecode.javaewah:JavaEWAH:0.3.2 +- com.tdunning:json:1.8 +- commons-lang:commons-lang:2.6 +- io.airlift:aircompressor:0.10 +- javax.jdo:jdo-api:3.0.1 +- joda-time:joda-time:2.9.9 +- net.sf.opencsv:opencsv:2.3 +- org.apache.avro:avro-mapred:1.8.2 +- org.apache.avro:avro:1.8.2 +- org.apache.commons:commons-lang3:3.3.2 +- org.apache.hive.shims:hive-shims-0.23:3.1.2 +- org.apache.hive.shims:hive-shims-common:3.1.2 +- org.apache.hive:hive-common:3.1.2 +- org.apache.hive:hive-llap-client:3.1.2 +- org.apache.hive:hive-llap-common:3.1.2 +- org.apache.hive:hive-metastore:3.1.2 +- org.apache.hive:hive-serde:3.1.2 +- org.apache.hive:hive-service-rpc:3.1.2 +- org.apache.hive:hive-spark-client:3.1.2 +- org.apache.hive:hive-standalone-metastore:3.1.2 +- org.apache.hive:hive-storage-api:3.1.2 +- org.apache.orc:orc-core:1.5.6 +- org.apache.orc:orc-shims:1.5.6 +- org.apache.orc:orc-tools:1.5.6 +- org.apache.parquet:parquet-hadoop-bundle:1.10.0 +- org.apache.parquet:parquet-jackson:1.10.0 Review comment: `parquet-jackson` was not listed in my hive build ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
