zentol commented on a change in pull request #12704:
URL: https://github.com/apache/flink/pull/12704#discussion_r442084444



##########
File path: 
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java
##########
@@ -285,9 +285,7 @@ public void run() {
                                if (!jobsToRemove.isEmpty() && 
processArchiveDeletion) {
                                        
events.addAll(cleanupExpiredJobs(jobsToRemove));
                                }
-                               if (!events.isEmpty()) {
-                                       updateJobOverview(webOverviewDir, 
webDir);
-                               }
+                               updateJobOverview(webOverviewDir, webDir);

Review comment:
       We could also call this once in the constructor; it is supposed to be 
part of the startup anyway.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to