wangyang0918 commented on a change in pull request #12054:
URL: https://github.com/apache/flink/pull/12054#discussion_r442712205
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -257,6 +257,18 @@
text("\"ip\" - uses host's ip address
as binding address"))
.build());
+ /**
+ * The prefix of the TaskManager's ResourceID. If configured, the
ResourceID will be generated with the prefix and a
+ * 6-character random string. Otherwise, a random string will be used.
Only valid in standalone mode.
+ */
+ @Documentation.Section(Documentation.Sections.ALL_TASK_MANAGER)
+ public static final ConfigOption<String>
TASK_MANAGER_RESOURCE_ID_PREFIX =
+ key("taskmanager.resource-id.prefix")
+ .stringType()
+ .noDefaultValue()
+ .withDescription("The prefix of the TaskManager's
ResourceID. If configured, the ResourceID will be generated with the prefix "
+ + "and a 6-character random string. Otherwise,
a random string will be used. Only valid in standalone mode.");
Review comment:
Yes, actually in FLINK-17579 we also want to start with environment
instead of config option. And we could unify all the current environment
name(e.g. `_FLINK_CONTAINER_ID`, `_FLINK_POD_NAME`) to
`TASK_MANAGER_RESOURCE_ID`. For active resourcemanager, we generate with
meaningful names and do not change the current behavior. And for standalone, it
could be specified with an arbitrary string(e.g. hostname, podname, etc.).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
