zentol commented on a change in pull request #12636:
URL: https://github.com/apache/flink/pull/12636#discussion_r442737356
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/HistoryServerOptions.java
##########
@@ -99,6 +99,13 @@
.withDescription("Enable HTTPs access to the
HistoryServer web frontend. This is applicable only when the" +
" global SSL flag security.ssl.enabled is set
to true.");
+ public static final ConfigOption<Integer> HISTORY_SERVER_RETAINED_JOBS =
+ key("historyserver.archive.retained-jobs")
+ .defaultValue(-1)
+ .withDescription(String.format("The maximum number of
jobs to retain in each archive directory" +
+ " defined by `%s`. If set to `-1`(default) or
negative, there is no limit to the number of archives" +
+ " to keep in the directories and the cache. If
set to `0`, no archives are kept.", HISTORY_SERVER_ARCHIVE_DIRS.key()));
Review comment:
I'd throw an `IllegalConfigurationException` if the value is 0 or
smaller than -1.
We can keep 0 as a reserved value for the future (e.g., if the HS should
show running jobs; or as a way to delete archives continuously without having
to redeploy a cluster to change the archiving configuration)
All other negative values should be rejected since they may imply a
user-error; say if the file is generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
