rkhachatryan commented on a change in pull request #12525:
URL: https://github.com/apache/flink/pull/12525#discussion_r442778779
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
##########
@@ -207,9 +209,8 @@ public void testCleanUpExceptionSuppressing() throws
Exception {
testHarness.waitForTaskCompletion();
}
catch (Exception ex) {
- if (!ExceptionUtils.findThrowable(ex,
ExpectedTestException.class).isPresent()) {
- throw ex;
- }
+ assertTrue(ex.getCause() instanceof
ExpectedTestException);
+
assertTrue(Iterables.getOnlyElement(asList(ex.getCause().getSuppressed()))
instanceof FailingTwiceOperator.DisposeException);
Review comment:
I think you are talking about tests that assert exception types
unnecessarily.
But here we indeed want to make sure that `DisposeException` **is** in the
list of suppressed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
