carp84 commented on pull request #12673: URL: https://github.com/apache/flink/pull/12673#issuecomment-646594875
I manually checked and confirmed any class extending `DefaultConfigurableOptionsFactory` won't compile if tries to overriding the old `createDBOptions(DBOptions currentOptions)` method since `RocksDBOptionsFactory` doesn't extend `OptionsFactory` anymore, and no more "silent API breaking issue" will occur. I'm planning to merge this tomorrow if no objections @StephanEwen @NicoK. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
