pnowojski commented on a change in pull request #11868:
URL: https://github.com/apache/flink/pull/11868#discussion_r442943015
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -500,8 +500,9 @@ private void setVertexConfig(Integer vertexID, StreamConfig
config,
config.setStateBackend(streamGraph.getStateBackend());
config.setCheckpointingEnabled(checkpointCfg.isCheckpointingEnabled());
-
config.setUnalignedCheckpointsEnabled(checkpointCfg.isUnalignedCheckpointsEnabled());
config.setCheckpointMode(getCheckpointingMode(checkpointCfg));
+
config.setUnalignedCheckpointsEnabled(config.getCheckpointMode() ==
CheckpointingMode.EXACTLY_ONCE &&
Review comment:
I guess I would prefer the most:
> We could fail on that combination. Then we would need to disable UC for
every at least once test. Not my favorite.
But this one is probably also fine:
> We disable/ignore UC (current way) with a warning (needs to be added).
But either way, I think this should deserve it's own ticket.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
