HuangZhenQiu edited a comment on pull request #11541: URL: https://github.com/apache/flink/pull/11541#issuecomment-646733511
@rkhachatryan Thanks for giving feedback on the PR. I think the PR is to tackle different things compare to taskmanager.network.request-backoff.xxx. taskmanager.network.request-backoff.xxx is translated into delayMs in NettyPartitionRequestClient to request sub Partition. It is after the TCP connection is built. The retry added here is to make TCP connection creation more reliable. It is not easy to combine it together. But it is a good suggestion, Let's wait for @pnowojski's feedback. Yes, you are right. The deadline is due to the UnstableNettyClient can't simulate the netty bootstrap to notify the exception to ConnectingChannel. Currently, the exception is thrown in connect function, so that we need to explicitly notify it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
