HuangZhenQiu commented on a change in pull request #11541:
URL: https://github.com/apache/flink/pull/11541#discussion_r442989698



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientFactory.java
##########
@@ -60,49 +71,41 @@ NettyPartitionRequestClient 
createPartitionRequestClient(ConnectionID connection
                while (client == null) {
                        entry = clients.get(connectionId);

Review comment:
       Yes, you are right. Usually the exception can be notified to the old 
connecting channel by bootstrap. The test case actually triggers the exception 
within the connect function, thus we need to notify the exception explicitly. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to