[ 
https://issues.apache.org/jira/browse/FLINK-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132242#comment-15132242
 ] 

ASF GitHub Bot commented on FLINK-3329:
---------------------------------------

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/1586

    [FLINK-3329] Auto-Close BackupEngine in AbstractRocksDBState

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink rocksdb-auto-close

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1586.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1586
    
----
commit 61a468981d49013e7baa7feda5ff41da75e454aa
Author: Aljoscha Krettek <[email protected]>
Date:   2016-02-04T12:25:34Z

    [FLINK-3329] Auto-Close BackupEngine in AbstractRocksDBState

----


> Unclosed BackupEngine in AbstractRocksDBState#snapshot()
> --------------------------------------------------------
>
>                 Key: FLINK-3329
>                 URL: https://issues.apache.org/jira/browse/FLINK-3329
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Aljoscha Krettek
>
> Here is related code:
> {code}
>       BackupEngine backupEngine = BackupEngine.open(Env.getDefault(),
>         new BackupableDBOptions(localBackupPath.getAbsolutePath()));
>       backupEngine.createNewBackup(db);
> {code}
> BackupEngine implements AutoCloseable.
> backupEngine should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to