libenchao commented on a change in pull request #12542:
URL: https://github.com/apache/flink/pull/12542#discussion_r443112258
##########
File path:
flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/data/DataFormatConvertersTest.java
##########
@@ -148,9 +148,18 @@ private static DataFormatConverter
getConverter(TypeInformation typeInfo) {
}
private static void test(TypeInformation typeInfo, Object value) {
+ test(typeInfo, value, null);
+ }
+
+ private static void test(TypeInformation typeInfo, Object value, Object
anotherValue) {
Review comment:
how about name `anotherValue` to `secondValue`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
