tzulitai commented on a change in pull request #126:
URL: https://github.com/apache/flink-statefun/pull/126#discussion_r443319284
##########
File path:
statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/state/PersistedStates.java
##########
@@ -26,14 +26,31 @@
import java.util.stream.Stream;
import javax.annotation.Nonnull;
import javax.annotation.Nullable;
+import org.apache.flink.statefun.sdk.FunctionType;
import org.apache.flink.statefun.sdk.annotations.Persisted;
import org.apache.flink.statefun.sdk.state.PersistedAppendingBuffer;
import org.apache.flink.statefun.sdk.state.PersistedTable;
import org.apache.flink.statefun.sdk.state.PersistedValue;
-final class PersistedStates {
+public final class PersistedStates {
Review comment:
I'd like to avoid naming this class a `*StateBinder` as well, to
differentiate it from an actual `StateBinder` implementation.
I chose to rename the static method to `findReflectivelyAndBind` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
