rkhachatryan commented on a change in pull request #12714:
URL: https://github.com/apache/flink/pull/12714#discussion_r444361745
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java
##########
@@ -139,6 +142,33 @@ public void testRegularExecution() throws Exception {
taskManagerActions.validateListenerMessage(ExecutionState.FINISHED, task, null);
}
+ @Test
+ public void testTaskTerminatesOnlyAfterInvokable() throws Exception {
Review comment:
> What's the problem with waiting on the latch as I proposed?
For how long should the test thread wait on the latch (assuming
`SourceStreamTask.sourceThread` never exits)?
Or did I misunderstood your proposal?
> It should provide automated test coverage for that bug.
It provides only partial coverage because it doesn't cover integration with
`Task`, `StreamTask` and the code that actually unloads the classes. So in
terms of coverage, it's equivalent to a set of unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
