sergiimk opened a new pull request #12768: URL: https://github.com/apache/flink/pull/12768
## What is the purpose of the change Current implementation of the Parquet reader decodes DECIMAL types incorrectly. It doesn't follow the spec and will either throw `NumberFormatException` or read incorrect values even on Parquet files produced by Flink itself. This PR updates the `ParquetSchemaConverter` and `RowConverter` to handle all 4 encoding styles specified by the [spec](https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#decimal): - `int32` - `int64` - `fixed_len_byte_array` - `binary` ## Brief change log - Parquet reader will decode DECIMAL type according to the spec ## Verifying this change This change added tests and can be verified as follows: - Added tests that validate DECIMAL decoding with all backing types specified by Parquet spec - Manually verified the change by reading Parquet files generated by Spark ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: yes - The runtime per-record code paths (performance sensitive): yes - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
